paul-rogers commented on a change in pull request #1954: DRILL-7509: Incorrect
TupleSchema is created for DICT column when querying Parquet files
URL: https://github.com/apache/drill/pull/1954#discussion_r366598557
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/MetadataUtils.java
##########
@@ -187,6 +187,10 @@ public static ColumnMetadata newMapArray(String name,
TupleMetadata schema) {
return new MapColumnMetadata(name, DataMode.REPEATED, (TupleSchema)
schema);
}
+ public static DictColumnMetadata newDictArray(String name, TupleMetadata
schema) {
+ return new DictColumnMetadata(name, DataMode.REPEATED, (TupleSchema)
schema);
Review comment:
Picking up on a comment in your PR description, I wonder if we have the
wrong semantics here. It is true that DICT is *implemented* as a map. But, at
the metadata (descriptive) level, it is not a map, and is not constructed from
a map; it is instead a `<KEY,VALUE>` pair.
I'm not sure we're doing ourselves a favor by exposing the implementation
detail (a kind of map) in our metadata description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
