cgivre commented on issue #1913: DRILL-6953: EVF-based version of the JSON reader URL: https://github.com/apache/drill/pull/1913#issuecomment-576433165 I would vote for option one. IMHO we should work for smaller PRs so that we can get code committed faster and hopefully less work for the reviewers. Sent from my iPhone > On Jan 20, 2020, at 16:16, Paul Rogers <[email protected]> wrote: > > > @vvysotskyi, @arina-ielchiieva - it turns out that a number of fixes are required to resolve the issues that came up in the tests run above. The full set of changes, with JSON and all the fixes, will be large. We should break them into smaller PRs. > > There are two ways to proceed. One is to commit this PR with the new reader disabled by default. Then apply fixes one by one for easier to review. Eventually, we enable the new reader when everything works. > > The other is that I make the fixes on this branch, then pull each out into a separate PR that we review before this one. The result is much extra work for me to do all the code copying/merging involved. > > How do you recommend we proceed? > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub, or unsubscribe.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
