dobesv edited a comment on issue #1977: DRILL-7573: Support htpasswd based authentication URL: https://github.com/apache/drill/pull/1977#issuecomment-584926786 @paul-rogers I added some tests and cleaned up the logic slightly. I didn't add tests for the REST API, since the password logic is shared between both systems I don't think this requires separate testing. I couldn't figure out a sane way to test the stuff related to the default path and I didn't do anything related to loading the file from the classpath. I think that might be more than I am capable of with the time budget I have for this task right now. I don't think the "default path" is particularly import nor is it particularly prone to regressions. I didn't attempt tests related to logging, it just doesn't seem worth it. I'm not so familiar with the project that I can make a test like that in a reasonable amount of time. Perhaps someone core to the team can add that if it seems important.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
