KazydubB commented on a change in pull request #1974: DRILL-7574: Generalize
the projection parser
URL: https://github.com/apache/drill/pull/1974#discussion_r377038532
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/RowSetTestUtils.java
##########
@@ -58,6 +58,10 @@ private RowSetTestUtils() { }
new SchemaPath[] {SchemaPath.STAR_COLUMN});
}
+ public static List<SchemaPath> projectNone() {
+ return new ArrayList<>();
Review comment:
Is it safe to return unmodifiable instance, such as
`Collections.emptyList()` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
