paul-rogers commented on a change in pull request #1985: DRILL-7565: ANALYZE
TABLE ... REFRESH METADATA does not work for empty Parquet files
URL: https://github.com/apache/drill/pull/1985#discussion_r379849962
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/metastore/analyze/MetadataAggregateContext.java
##########
@@ -63,8 +67,8 @@ public boolean createNewAggregations() {
}
@JsonProperty
- public List<SchemaPath> excludedColumns() {
- return excludedColumns;
+ public List<SchemaPath> nonSchemaColumns() {
Review comment:
Maybe "metadataColumn" or "implicitColumns"? From a pure implementation
perspective, every column is a schema column for some schema. Please pick a
name that explains their use: "statisticsColumns"?
And, thank you for renaming this. I would have guessed that
"excludedColumns" were those in the file that are not being projected in this
query, which would then have seemed very odd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
