paul-rogers commented on a change in pull request #1987: DRILL-7589: Set
temporary tests folder for UDF_DIRECTORY_LOCAL, fix allocators closing in
BloomFilterTest, fix permissions issue for TestGracefulShutdown tests
URL: https://github.com/apache/drill/pull/1987#discussion_r380485678
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java
##########
@@ -73,31 +73,39 @@ private static void
enableDrillPortHunting(ClusterFixtureBuilder builder) {
builder.configBuilder.put(ExecConstants.DRILL_PORT_HUNT, true);
builder.configBuilder.put(ExecConstants.GRACE_PERIOD, 500);
builder.configBuilder.put(ExecConstants.ALLOW_LOOPBACK_ADDRESS_BINDING,
true);
+
+ setTestDirectories(builder);
+ }
+
+ private static void setTestDirectories(ClusterFixtureBuilder builder) {
+ builder.configBuilder.put(ExecConstants.DRILL_TMP_DIR,
dirTestWatcher.getTmpDir().getAbsolutePath());
+ builder.configBuilder.put(ExecConstants.SYS_STORE_PROVIDER_LOCAL_PATH,
dirTestWatcher.getStoreDir().getAbsolutePath());
Review comment:
Can this be done in `ClusterFixture` or its builder so we use a consistent
set of directories everywhere? I've been burned by these being a bit
ill-defined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
