arina-ielchiieva commented on a change in pull request #1978: DRILL-7578: HDF5 Metadata Queries Fail with Large Files URL: https://github.com/apache/drill/pull/1978#discussion_r383908899
########## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ########## @@ -946,7 +988,11 @@ private void writeAttributes(TupleWriter rowWriter, HDF5DrillMetadata record) { writeLongColumn(mapWriter, key, (Long) attrib.getValue()); break; case INT: - writeIntColumn(mapWriter, key, (Integer) attrib.getValue()); + try { + writeIntColumn(mapWriter, key, (Integer) attrib.getValue()); + } catch (Exception e) { + System.out.println(key + " " + attrib.toString()); Review comment: Please remove and do proper error handling. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services