arina-ielchiieva commented on a change in pull request #1988: DRILL-7590:
Refactor plugin registry
URL: https://github.com/apache/drill/pull/1988#discussion_r383982716
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/PluginBootstrapLoader.java
##########
@@ -17,6 +17,22 @@
*/
package org.apache.drill.exec.store;
-public interface DistributedStorageEngine {
- public String getDfsName();
+import java.io.IOException;
+
+import org.apache.drill.exec.planner.logical.StoragePlugins;
+
+/**
+ * Generalized interface for bootstraping or upgrading the plugin persistent
+ * store. Provides the list of bootstrap plugins, along with those to be
+ * upgraded. Provides confirmation that the upgrade was performed to avoid
+ * doing it again.
+ * <p>
+ * <b>Caveats:</b>: The upgrade mechanism is rather ad-hoc; it actually needs
+ * a version number to be solid, but the persistent store does not currently
+ * provide a version number.
+ */
+public interface PluginBootstrapLoader {
+ StoragePlugins bootstrapPlugins() throws IOException;
+ StoragePlugins updatedPlugins();
+ void onUpgrade();
Review comment:
Please add java doc for this method in particular, since it's not clear what
it does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
