arina-ielchiieva commented on issue #1988: DRILL-7590: Refactor plugin registry
URL: https://github.com/apache/drill/pull/1988#issuecomment-591951040
 
 
   @paul-rogers thanks for making changes and addressing code review comments.
   Now you have one minor comment to address and to resolve the conflicts.
   Also we should ensure that DRILL-7030 functionality works. I have left 
detailed comment explaining it's purpose and checked on master, currently it 
works just fine.
   
   Regarding `TestDynamicUDFSupport`, there were some fixes to ensure test pass 
so before investigating, please rebase to the latest master, this might save 
you from doing unnecessary investigation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to