paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390561752
########## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpStoragePlugin.java ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.store.http; + +import org.apache.calcite.schema.SchemaPlus; +import org.apache.drill.common.JSONOptions; +import org.apache.drill.exec.physical.base.AbstractGroupScan; +import org.apache.drill.exec.server.DrillbitContext; +import org.apache.drill.exec.store.AbstractStoragePlugin; +import org.apache.drill.exec.store.SchemaConfig; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.core.type.TypeReference; +import java.io.IOException; + +public class HttpStoragePlugin extends AbstractStoragePlugin { + + private final DrillbitContext context; + + private final HttpStoragePluginConfig engineConfig; + + private final HttpSchemaFactory schemaFactory; + + public HttpStoragePlugin(HttpStoragePluginConfig configuration, DrillbitContext context, String name) { + super(context, name); + engineConfig = configuration; + schemaFactory = new HttpSchemaFactory(this, name); + this.context = context; + } + + @Override + public void registerSchemas(SchemaConfig schemaConfig, SchemaPlus parent) { + schemaFactory.registerSchemas(schemaConfig, parent); + } + + @Override + public HttpStoragePluginConfig getConfig() { + return engineConfig; + } + + @Override + public DrillbitContext getContext() { + return context; + } + + @Override + public boolean supportsRead() { + return true; + } + + @Override + public AbstractGroupScan getPhysicalScan(String userName, JSONOptions selection) throws IOException { + HttpScanSpec scanSpec = selection.getListWith(new ObjectMapper(), new TypeReference<HttpScanSpec>() {}); Review comment: So I discovered that the right way to do this is not to create your own mapper, but rather to use the intuitively obvious: ``` context.getLpPersistence().getMapper(); ``` Which has all the Drill Jackson goodies built in. Here `context` is the `DrillbitContext` from the base class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
