vvysotskyi commented on a change in pull request #2037: DRILL-7648: Scrypt
j_security_check works without security headers
URL: https://github.com/apache/drill/pull/2037#discussion_r396494612
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillHttpSecurityHandlerProvider.java
##########
@@ -54,11 +55,14 @@
private final Map<String, DrillHttpConstraintSecurityHandler>
securityHandlers =
CaseInsensitiveMap.newHashMapWithExpectedSize(2);
+ private final BiConsumer<HttpServletRequest, HttpServletResponse>
preHandleCallback;
+
@SuppressWarnings("unchecked")
- public DrillHttpSecurityHandlerProvider(DrillConfig config, DrillbitContext
drillContext)
+ public DrillHttpSecurityHandlerProvider(DrillConfig config, DrillbitContext
drillContext,
+ BiConsumer<HttpServletRequest,
HttpServletResponse> preHandleCallback)
Review comment:
Passing `BiConsumer` looks slightly complicated. Is it possible either to
pass map with response headers or obtain headers from `DrillConfig` again and
use it where needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
