arina-ielchiieva commented on a change in pull request #2018: DRILL-7633: Fixes 
for union and repeated list accessors
URL: https://github.com/apache/drill/pull/2018#discussion_r397109112
 
 

 ##########
 File path: 
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/AbstractColumnMetadata.java
 ##########
 @@ -295,12 +295,6 @@ public String toString() {
         .toString();
   }
 
-  @JsonProperty("type")
-  @Override
-  public String typeString() {
-    return majorType().toString();
-  }
-
 
 Review comment:
   Please don't remove this method but leave it as abstract with json property 
annotation:
   ```
     @JsonProperty("type")
     @Override
     public abstract String typeString();
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to