ihuzenko commented on a change in pull request #2038: DRILL-6604: Upgrade Drill Hive client to Hive3.1 version URL: https://github.com/apache/drill/pull/2038#discussion_r399110724
########## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/writers/primitive/HiveTimestampWriter.java ########## @@ -18,21 +18,23 @@ package org.apache.drill.exec.store.hive.writers.primitive; import org.apache.drill.exec.vector.complex.writer.TimeStampWriter; -import org.apache.hadoop.hive.serde2.objectinspector.primitive.TimestampObjectInspector; +import org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector; +import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorUtils; import org.joda.time.DateTime; import org.joda.time.DateTimeZone; -public class HiveTimestampWriter extends AbstractSingleValueWriter<TimestampObjectInspector, TimeStampWriter> { +public class HiveTimestampWriter extends AbstractSingleValueWriter<PrimitiveObjectInspector, TimeStampWriter> { - public HiveTimestampWriter(TimestampObjectInspector inspector, TimeStampWriter writer) { + public HiveTimestampWriter(PrimitiveObjectInspector inspector, TimeStampWriter writer) { super(inspector, writer); } @Override public void write(Object value) { - final java.sql.Timestamp timestampValue = inspector.getPrimitiveJavaObject(value); - final DateTime ts = new DateTime(timestampValue.getTime()).withZoneRetainFields(DateTimeZone.UTC); - writer.writeTimeStamp(ts.getMillis()); + String timestampString = PrimitiveObjectInspectorUtils.getString(value, inspector); + long milliseconds = new DateTime(java.sql.Timestamp.valueOf(timestampString).getTime()) Review comment: ```suggestion long timestampMillis = new DateTime(java.sql.Timestamp.valueOf(timestampString).getTime()) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services