arina-ielchiieva commented on issue #2052: DRILL-7603 and DRILL-7604: Add 
schema, options to REST query
URL: https://github.com/apache/drill/pull/2052#issuecomment-612420174
 
 
   @paul-rogers changes look good but I have two questions:
   1. the screenshot in the PR title does not show how options will be 
described from WEB UI. Looks like this part of the implementation is missing. I 
think since we allow passing options through REST API to have ability to set 
them on query page.
   2. When default schema was added, case when user was able to return query 
from Profiles was missed (see 
https://issues.apache.org/jira/browse/DRILL-7655). Should be this covered in 
your changes as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to