arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF
v2 scan schema resolution
URL: https://github.com/apache/drill/pull/2051#discussion_r407074521
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/AbstractColumnMetadata.java
##########
@@ -295,6 +285,8 @@ public String toString() {
.toString();
}
+ protected void appendContents(StringBuilder buf) { }
+
@JsonProperty("type")
@Override
public String typeString() {
Review comment:
Better make this abstract since all columns which implement this, must
ensure parser can parse string back to type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
