paul-rogers commented on issue #2054: DRILL-6168: Revise format plugin table functions URL: https://github.com/apache/drill/pull/2054#issuecomment-615472724 @arina-ielchiieva, the above analysis shows that this PR provides the correct results, the prior code and tests verified incorrect results. So, let's do this: 1. Approve and commit this PR. 2. Immediately update the four faulty expected results (`_e`) files in the test framework. 3. Rerun the selected tests to verify the test fixes. Note that we cannot reverse the order: if we change the tests first, all runs except this PR will fail. It would be ideal to have two sets of results: one before this PR, one after. Or, disable the four tests for commits before this PR. But, the test framework does not seem to have version awareness. Unfortunately, I'm not yet set up to run the test framework. I can, however, fix the result files. Should I do a PR against the test framework?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
