arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework URL: https://github.com/apache/drill/pull/2056#discussion_r410711431
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/file/FileScanLifecycle.java ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.physical.impl.scan.v3.file; + +import java.io.IOException; + +import org.apache.drill.common.exceptions.UserException; +import org.apache.drill.exec.ops.OperatorContext; +import org.apache.drill.exec.physical.impl.scan.v3.lifecycle.ReaderLifecycle; +import org.apache.drill.exec.physical.impl.scan.v3.lifecycle.ScanLifecycle; +import org.apache.drill.exec.physical.impl.scan.v3.lifecycle.SchemaNegotiatorImpl; +import org.apache.drill.exec.physical.impl.scan.v3.lifecycle.StaticBatchBuilder; +import org.apache.drill.exec.store.dfs.DrillFileSystem; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * The file scan framework adds into the scan framework support for + * reading from DFS splits (a file and a block) and for the file-related + * implicit and partition columns. The file scan builder gathers + * file-related options for the scan as a whole, including the list + * of splits. The associated {@link FileSchemaNegotiator} passes + * file information to each reader. + * <p> + * Only a single storage plugin uses the file scan framework: + * the {@link FileSystemPlugin} via the {@link EasyFormatPlugin}. To + * make client code as simple as possible, the Drill file system and list + * of files is passed though this framework to the + * {@link FileReaderFactory}, then to the {@link FileSchemaNegotiator} + * which presents them to the reader. This approach avoids the need + * for each format handle this common boilerplate code. + * <p> + * The {@link FileSanOptions} holds the list of splits to scan. The Review comment: ```suggestion * The {@link FileScanOptions} holds the list of splits to scan. The ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
