vvysotskyi commented on a change in pull request #2060: DRILL-7706: Implement Drill RDBMS Metastore for Tables component URL: https://github.com/apache/drill/pull/2060#discussion_r410730382
########## File path: metastore/rdbms-metastore/src/main/resources/db/changelog/changes/initial_ddls.yaml ########## @@ -0,0 +1,397 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# Creates 5 RDBMS Metastore tables component tables: TABLES, SEGMENTS, FILES, ROW_GROUPS, PARTITIONS. +databaseChangeLog: + # to preserve upper case naming in some DBs (ex: PostgreSQL) and quote reserved column names (ex: COLUMN) + - objectQuotingStrategy: QUOTE_ALL_OBJECTS + - changeSet: + id: 1 + author: arina + changes: + - createTable: + tableName: TABLES + columns: + - column: + name: STORAGE_PLUGIN + type: VARCHAR(100) + constraints: + primaryKey: true + nullable: false + - column: + name: WORKSPACE + type: VARCHAR(100) + constraints: + primaryKey: true + nullable: false + - column: + name: TABLE_NAME + type: VARCHAR(200) + constraints: + primaryKey: true + nullable: false + - column: + name: OWNER + type: VARCHAR(100) + - column: + name: TABLE_TYPE + type: VARCHAR(100) + - column: + name: METADATA_KEY + type: VARCHAR(100) + constraints: + nullable: false + - column: + name: METADATA_TYPE + type: VARCHAR(100) + constraints: + nullable: false + - column: + name: LOCATION + type: VARCHAR(500) Review comment: Realy a good choice for this value. Though some linux-based systems limit its size to 256 bytes, other systems like Windows removed the existing 260 characters limit. So I think 500 value is fine. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
