paul-rogers commented on a change in pull request #2060: DRILL-7706: Implement Drill RDBMS Metastore for Tables component URL: https://github.com/apache/drill/pull/2060#discussion_r410831759
########## File path: metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/components/tables/RdbmsTables.java ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.metastore.rdbms.components.tables; + +import org.apache.drill.metastore.components.tables.TableMetadataUnit; +import org.apache.drill.metastore.components.tables.Tables; +import org.apache.drill.metastore.components.tables.TablesMetadataTypeValidator; +import org.apache.drill.metastore.operate.Metadata; +import org.apache.drill.metastore.operate.Modify; +import org.apache.drill.metastore.operate.Read; +import org.apache.drill.metastore.rdbms.QueryExecutorProvider; +import org.apache.drill.metastore.rdbms.RdbmsMetastoreContext; +import org.apache.drill.metastore.rdbms.operate.RdbmsMetadata; +import org.apache.drill.metastore.rdbms.operate.RdbmsModify; +import org.apache.drill.metastore.rdbms.operate.RdbmsRead; +import org.apache.drill.metastore.rdbms.transform.Transformer; + +/** + * Metastore Tables component which stores tables metadata in the corresponding RDBMS tables: + * TABLES, SEGMENTS, FILES, ROW_GROUPS, PARTITIONS. + * Provides methods to read and modify tables metadata. + */ +public class RdbmsTables implements Tables, RdbmsMetastoreContext<TableMetadataUnit> { Review comment: The term "tables" in a query engine is excessively overloaded. Do we mean system tables, the physical table on disk, a Calcite representation of a table, the metadata description of a table, ...? Perhaps rename the classes `TableMetadata` or `TableDescription` (you pick a name) and `RdbmsTableWhatever`. Else, my first thought was that this is the class that will manage the tables (there is that term again) we created in the RDBMS. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
