vvysotskyi commented on a change in pull request #2071: URL: https://github.com/apache/drill/pull/2071#discussion_r418724733
########## File path: contrib/native/client/CMakeLists.txt ########## @@ -25,6 +25,13 @@ cmake_policy(SET CMP0043 NEW) cmake_policy(SET CMP0048 NEW) enable_testing() +# +# required version for dependencies +# +set (BOOST_MINIMUM_VERSION 1.54.0) +set (PROTOBUF_MINIMUM_VERSION 3.6.1) Review comment: It may cause issues for other places since protobuf files were regenerated using 3.11 version. Looks like updating `readme.win.txt` instruction was missed and should be fixed to be up-to-date. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org