cgivre commented on pull request #2092: URL: https://github.com/apache/drill/pull/2092#issuecomment-711166293
@vvysotskyi Thanks for looking at this. I fixed the import order, removed the `TODO` and took care of the `print` statement. Regarding the one remaining comment about modifying the groupScan. Originally, I had a separate constructor which applied the `maxLimit` to the GroupScan for this purpose. I believe in previous comments, you asked to remove this, which I did. The goal here really is just make the limit available to `recordReaders` so that they can stop reading if it makes sense to do so. If I shouldn't add an additional constructor to the `AbstractGroupScan`, and I shouldn't modify it, how would you suggest populating this field? Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
