nielsbasjes commented on pull request #2122: URL: https://github.com/apache/drill/pull/2122#issuecomment-740733560
So I tried to fix the test which was really hard because the ordering of the columns in case of a wildcard was based on the hash (i.e. visually random). - I made the ordering of the columns in case of the wildcard a stable textual ordering (by means of a TreeMap instead of a HashMap). - I found that the Casts were the same for all columns (which is incorrect, so I fixed that). - As a consequence the tests become much easier to read because everything is sorted. At this point I think the type remapping doesn't work. I haven't seen any testing code or documentation so I'm not sure. Because of the lack of testing I'm pretty sure one of my changes broke it. @cgivre If you can please give me a hint on how you intended it to work I can pick that up for a test to include. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
