cgivre commented on a change in pull request #2164:
URL: https://github.com/apache/drill/pull/2164#discussion_r584211789
##########
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
##########
@@ -237,37 +242,37 @@ public boolean open(FileSchemaNegotiator negotiator) {
* This function is called when the default path is set and the data set is
a single dimension.
* This function will create an array of one dataWriter of the
* correct datatype
- * @param dsInfo The HDF5 dataset information
+ * @param dataset The HDF5 dataset
*/
- private void buildSchemaFor1DimensionalDataset(HDF5DataSetInformation
dsInfo) {
- TypeProtos.MinorType currentDataType = HDF5Utils.getDataType(dsInfo);
+ private void buildSchemaFor1DimensionalDataset(Dataset dataset) {
+ MinorType currentDataType = HDF5Utils.getDataType(dataset.getDataType());
// Case for null or unknown data types:
if (currentDataType == null) {
- logger.warn("Couldn't add {}",
dsInfo.getTypeInformation().tryGetJavaType().toGenericString());
+ logger.warn("Couldn't add {}", dataset.getJavaType().getName());
return;
}
dataWriters.add(buildWriter(currentDataType));
}
- private HDF5DataWriter buildWriter(TypeProtos.MinorType dataType) {
+ private HDF5DataWriter buildWriter(MinorType dataType) {
switch (dataType) {
- case GENERIC_OBJECT:
- return new HDF5EnumDataWriter(hdf5Reader, writerSpec,
readerConfig.defaultPath);
+ /*case GENERIC_OBJECT:
+ return new HDF5EnumDataWriter(hdfFile, writerSpec,
readerConfig.defaultPath);*/
Review comment:
I wanted to ask about this. I encountered a datatype in an HDF5 file
which I cannot find which was an `enum` type. Have you seen this before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
