dzamo commented on pull request #2351: URL: https://github.com/apache/drill/pull/2351#issuecomment-967044407
@vvysotskyi @vdiravka judging by that those test results, I did an incomplete job of changing `PARQUET_READER_STRINGS_SIGNED_MIN_MAX` from string to boolean. Just ignore that for now please, since before I fix it (or revert it) I'd like to ask you some things. 1. Is it possible to change an existing config option to a more restrictive type, as mentioned above, with breaking upgradeability. I don't need to do that for my PR, I was just trying to clean up things nearby. 2. The code to apply parquet config opts and session opts according to priority has been put in ParquetFormatPlugin. Should I move it ParquetFormatConfig instead? Perhaps in the individual getters? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
