dzamo commented on a change in pull request #2351:
URL: https://github.com/apache/drill/pull/2351#discussion_r752001140
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java
##########
@@ -78,6 +80,8 @@
public class ParquetFormatPlugin implements FormatPlugin {
+ public static final String[] PARQUET_VERSIONS = {"PARQUET_1_0",
"PARQUET_2_0"};
Review comment:
@vdiravka I followed `ParquetProperties#WriterVersion`, that's where
`PARQUET_1_0` and `PARQUET_2_0` come from. I agree it's clunky, but on the
plus side I did not have to introduce any new version format strings or case
statements. Which do you think is preferable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
