cgivre commented on a change in pull request #2387: URL: https://github.com/apache/drill/pull/2387#discussion_r767202665
########## File path: contrib/storage-druid/README.md ########## @@ -4,13 +4,13 @@ Drill druid storage plugin allows you to perform SQL queries against Druid datas This storage plugin is part of [Apache Drill](https://github.com/apache/drill) ### Tested with Druid version -[0.16.0-incubating](https://github.com/apache/incubator-druid/releases/tag/druid-0.16.0-incubating) +[0.22.0](https://github.com/apache/druid/releases/tag/druid-0.22.0) Review comment: Are there any versions of Druid that this will NOT work with? If so, maybe say that this will work with Druid > n or whatever.... I'm not very knowledgable of Druid, so I don't really know if that is even relevant. ########## File path: contrib/storage-druid/src/test/java/org/apache/drill/exec/store/druid/rest/DruidQueryClientTest.java ########## @@ -90,23 +90,23 @@ public void executeQueryCalledNoResponsesFoundReturnsEmptyEventList() new ByteArrayInputStream("[]".getBytes(StandardCharsets.UTF_8.name())); when(httpEntity.getContent()).thenReturn(inputStream); - DruidSelectResponse response = druidQueryClient.executeQuery(QUERY); + DruidScanResponse response = druidQueryClient.executeQuery(QUERY); assertThat(response.getEvents()).isEmpty(); - assertThat(response.getPagingIdentifiers()).isEmpty(); + //assertThat(response.getPagingIdentifiers()).isEmpty(); Review comment: Please remove commented out code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
