cgivre commented on a change in pull request #2401:
URL: https://github.com/apache/drill/pull/2401#discussion_r784053795



##########
File path: 
logical/src/main/java/org/apache/drill/common/logical/security/CredentialsProvider.java
##########
@@ -33,6 +37,16 @@
    * Returns map with authentication credentials. Key is the credential name, 
for example {@code "username"}
    * and map value is corresponding credential value.
    */
+  static final Logger logger = 
LoggerFactory.getLogger(CredentialsProvider.class);
+
   @JsonIgnore
   Map<String, String> getCredentials();
+
+  @JsonIgnore
+  default void updateCredentials(String key, String value) throws 
UserException {
+    throw UserException.internalError()
+      .message("Update credential function not implemented for " + Id.NAME)
+      .build(logger);
+  }

Review comment:
       Fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to