jnturton commented on pull request #2419: URL: https://github.com/apache/drill/pull/2419#issuecomment-1023990781
> @jnturton A key reason this one has "unrelated" stuff is that those fixes were needed to get a clean build. So, maybe I can make those fixes in one PR and move this one to a draft until the preliminaries are merged, then rebase and do this one. Over the weekend I'll see what can be done. Thank you @paul-rogers. The timestamp changes aren't needed for a clean build _here in the GitHub CI_, even if that's only because it happens on UTC machines. So I think that they are not really a prerequisite for merging EVF v2. Additionally, in my tests the timestamp changes introduce a new bug (exhibited on the Jira issue). So in my opinion the opposite merge ordering is preferable once they're split out. First we should merge EVF v2, which looks great and not deserving of being sent back to draft, _then_ we can relook our zoneless timestamps and possible short and long term fixes. Obviously we do want the build and all tests to start working on non-UTC machines, but that is not EVF v2's cross to bear? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
