pjfanning commented on PR #2483: URL: https://github.com/apache/drill/pull/2483#issuecomment-1140337017
@luocooong @cgivre I'm not sure how unit-testable these changes are. To really test the features would require very large xlsx files and even with the all the new settings in place, the tests would be slow to run and use a lot of memory. Would it be feasible to treat these properties as something that users would only need to set in rare circumstances? If users run into issues with the properties in real world scenarios, then maybe the code and tests can be beefed up then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
