cgivre commented on code in PR #2580:
URL: https://github.com/apache/drill/pull/2580#discussion_r908624673
##########
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java:
##########
@@ -271,8 +292,11 @@ public void applyAssignments(List<DrillbitEndpoint>
incomingEndpoints) {
@Override
public GroupScan applyLimit(int maxRecords) {
- records = maxRecords; // Just apply the limit value into sub-scan
- return super.applyLimit(maxRecords);
+ if (maxRecords > records) { // pass the limit value into sub-scan
+ return new KafkaGroupScan(this, maxRecords);
+ } else { // stop the transform
+ return super.applyLimit(maxRecords);
Review Comment:
Do we still need to call the `super` method here? Could we just return
`null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
