jnturton commented on PR #2584:
URL: https://github.com/apache/drill/pull/2584#issuecomment-1174759621

   Okay, I did indeed not do proper job of backporting DRILL-8227 / #2551. 
Please may you add a new commit to your PR with a commit message like
   
   ```
   DRILL-8227: JConnect and jTDS JDBC drivers do not implement 
Connection::getSchema
   
   Fix build errors in the original backport attempt (aa5341df6).
   ```
   
   which removes AuthMode references from TestJdbcPluginWithMSSQL as follows.
   
   ```
   diff --git 
a/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
 
b/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
   index 68c687126..5b7b5d892 100644
   --- 
a/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
   +++ 
b/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
   @@ -19,7 +19,6 @@ package org.apache.drill.exec.store.jdbc;
    
    import org.apache.drill.categories.JdbcStorageTest;
    import org.apache.drill.common.logical.security.PlainCredentialsProvider;
   -import org.apache.drill.common.logical.StoragePluginConfig.AuthMode;
    import org.apache.drill.common.types.TypeProtos.MinorType;
    import org.apache.drill.exec.physical.rowSet.DirectRowSet;
    import org.apache.drill.exec.physical.rowSet.RowSet;
   @@ -86,7 +85,6 @@ public class TestJdbcPluginWithMSSQL extends ClusterTest {
          false,
          sourceParms,
          credentialsProvider,
   -      AuthMode.SHARED_USER.name(),
          100000
        );
        jdbcStorageConfig.setEnabled(true);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to