[GitHub] [drill] jnturton commented on pull request #2582: [Minor Update] Try and reduce the vm crash on fork

[GitBox]

jnturton commented on PR #2582:
URL: https://github.com/apache/drill/pull/2582#issuecomment-1175030561

   Hi @luocooong, please see if the changes in the following patch might allow 
keep the SNPEGO tests enabled. They correct copy-and-paste errors I found 
causing conflicting directory use.
   
   diff --git 
a/exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/spnego/TestDrillSpnegoAuthenticator.java
 
b/exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/spnego/TestDrillSpnegoAuthenticator.java
   index 643af83bf..22b574889 100644
   --- 
a/exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/spnego/TestDrillSpnegoAuthenticator.java
   +++ 
b/exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/spnego/TestDrillSpnegoAuthenticator.java
   @@ -67,7 +67,6 @@ import static org.mockito.Mockito.verify;
    /**
     * Test for validating {@link DrillSpnegoAuthenticator}
     */
   -@Ignore("See DRILL-5387")
    @Category(SecurityTest.class)
    public class TestDrillSpnegoAuthenticator extends BaseTest {
    
   @@ -81,7 +80,7 @@ public class TestDrillSpnegoAuthenticator extends BaseTest 
{
    
      @BeforeClass
      public static void setupTest() throws Exception {
   -    spnegoHelper = new 
KerberosHelper(TestSpnegoAuthentication.class.getSimpleName(), primaryName);
   +    spnegoHelper = new 
KerberosHelper(TestDrillSpnegoAuthenticator.class.getSimpleName(), primaryName);
        spnegoHelper.setupKdc(dirTestWatcher.getTmpDir());
    
        // (1) Refresh Kerberos config.
   diff --git 
a/exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/spnego/TestSpnegoConfig.java
 
b/exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/spnego/TestSpnegoConfig.java
   index a91f80231..3d6a8cc21 100644
   --- 
a/exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/spnego/TestSpnegoConfig.java
   +++ 
b/exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/spnego/TestSpnegoConfig.java
   @@ -55,7 +55,7 @@ public class TestSpnegoConfig extends BaseTest {
    
      @BeforeClass
      public static void setupTest() throws Exception {
   -    spnegoHelper = new 
KerberosHelper(TestSpnegoAuthentication.class.getSimpleName(), primaryName);
   +    spnegoHelper = new 
KerberosHelper(TestSpnegoConfig.class.getSimpleName(), primaryName);
        spnegoHelper.setupKdc(dirTestWatcher.getTmpDir());
    
        // (1) Refresh Kerberos config.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org