[GitHub] [drill] jnturton commented on pull request #2638: DRILL-8136: Overhaul implict type casting logic

[GitBox]

jnturton commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1242020822

   > This is really a MAJOR usability improvement. Will it also be able to cast 
`"true"` and `"false"` as boolean values? Likewise for:
   > 
   >     * True
   > 
   >     * TRUE
   > 
   >     * TrUe
   > 
   > 
   > etc....
   
   It's prepared to try. There situations in which things break elsewhere.
   ```
   1 row selected (0.576 seconds)
   apache drill> select not('true');
   EXPR$0  false
   
   1 row selected (0.184 seconds)
   apache drill> select not('false');
   EXPR$0  true
   
   1 row selected (0.151 seconds)
   apache drill> select not('False');
   EXPR$0  true
   
   1 row selected (0.142 seconds)
   apache drill> select not('TRUE');
   EXPR$0  false
   
   1 row selected (0.12 seconds)
   apache drill> select not('FaLsE');
   EXPR$0  true
   
   1 row selected (0.127 seconds)
   
   apache drill> select and(true, 'false');
   Error: SYSTEM ERROR: IllegalArgumentException: Input does not have type of 
BitHolder or NullableBitHolder.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org