jnturton commented on code in PR #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r968538795
##########
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java:
##########
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws Exception {
@Test
public void invalidPolicy() throws Exception {
- thrownException.expect(new
UserExceptionMatcher(UserBitShared.DrillPBError.ErrorType.VALIDATION,
- "Invalid impersonation policies."));
+ String query = "ALTER SYSTEM SET `%s`='%s'";
Review Comment:
Ah, okay. In that case I think we can go two ways here, since upgrading this
test, or family of tests, to ClusterTest could be a significant expansion of
PR's scope.
1. We can merge this as it is and leave the ClusterTest work for another PR
or
2. we can expand the scope here and you can convert BaseTestImpersonation
from PlanTestBase to ClusterTest. I believe that ClusterTest offers the plan
string matching features in PlanTestBase.
I leave the choice for you to make based on which way you prefer to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
