jnturton commented on PR #1750:
URL: https://github.com/apache/drill/pull/1750#issuecomment-1256153990

   Hi Kunal! Thank you for this contribution, I'd like to help to move it 
forward. 
   
   > However, I am not sure if we should automatically index any new profile 
that has been copy-pasted into the root dir. For e.g., we might get a profile 
from a JIRA and would like to view it. Should we leave it there (and try to 
render it) or should we index it ASAP ?
   
   I share your concern here.  I think we should consider having Drill only 
write _new_ profiles to partitioned directories. Any partitioning of historical 
profiles can be done externally by admins, in my opinion, and we can add 
examples of "housekeeping" scripts for doing that to the Drill documentation.
   
   Would you like to do any of the following?
   
   - Resume the work on this PR, I volunteer to be a reviewer.
   - Receive a PR from me to your fork here that's rebased and has some changes 
I think we want.
   - You're too busy now, so I'll pull your commits here into a new branch of 
my own and open a new PR.
   
   Thanks
   James


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to