pjfanning commented on PR #2665: URL: https://github.com/apache/drill/pull/2665#issuecomment-1268917234
@cgivre My PR uses the latest Spark code for the SizeEstimator as opposed to very old copy of the Spark code that was copied and not maintained in java-sizeof lib. The new code gives slightly higher estimates for object instance sizes. Would this be an issue? Also, with tests - Spark and the java-sizeof lib use some Scala based tests - and they are not that easily replicated in Java. The question is whether the tests that I've added in this PR or if I need more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
