cgivre commented on code in PR #2667:
URL: https://github.com/apache/drill/pull/2667#discussion_r988459145
##########
contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsStoragePlugin.java:
##########
@@ -61,6 +62,7 @@ public class GoogleSheetsStoragePlugin extends
AbstractStoragePlugin {
private final OAuthTokenProvider tokenProvider;
private DataStore<StoredCredential> dataStore;
private Sheets service;
+ private Drive driveService;
Review Comment:
@jnturton I don't think they need to be closed. These objects are really
more like containers for the various bits that go into calling the Google APIs.
They don't actually open any input streams, at least I don't think they do.
You can see that when we actually pull data from Google, there is some
convoluted call which ends in `execute`. That makes the actual HTTP call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
