jnturton opened a new pull request, #2694:
URL: https://github.com/apache/drill/pull/2694

   # [DRILL-8345](https://issues.apache.org/jira/browse/DRILL-8345): Replace 
maven.multiModuleProjectDirectory with session.executionRootDirectory
   
   ## Description
   
   The Maven resources plugin makes use of the undocumented variable 
maven.multiModuleProjectDirectory to copy /git.properties to target/classes in 
every sub-module. This variable breaks the project build in Eclipse 2022-03, 
even when a .mvn directory is present at the project root, and was probably 
never meant for use by the public. Replacing it with the 
session.executionRootDirectory Maven variable fixes the build in Eclipse and 
retains the intended copying of git.properties during builds.
   
   
   ## Documentation
   N/A
   
   ## Testing
   Import the Drill Maven project from scratch into Eclipse 2022-03 and run a 
unit test
   Import the Drill Maven project from scratch into IDEA 2021.2.4 and run a 
unit test
   Delete all but the root git.properties then build the project using mvn and 
check that a git.properties is present in target/classes of all modules.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to