cgivre commented on code in PR #2689: URL: https://github.com/apache/drill/pull/2689#discussion_r1008080601
########## contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestDateUtils.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.udfs; + +import org.junit.Test; + +import java.time.LocalDate; +import java.time.LocalDateTime; + +import static org.junit.Assert.assertEquals; + +public class TestDateUtils { + + @Test + public void testDateFromString() { + LocalDate testDate = LocalDate.of(2022, 3,14); + LocalDate badDate = LocalDate.of(1970, 1, 1); + assertEquals(testDate, DateUtilFunctions.getDateFromString("2022-03-14")); + assertEquals(testDate, DateUtilFunctions.getDateFromString("3/14/2022")); + assertEquals(testDate, DateUtilFunctions.getDateFromString("14/03/2022", true)); + assertEquals(testDate, DateUtilFunctions.getDateFromString("2022/3/14")); + + // Test bad dates + assertEquals(badDate, DateUtilFunctions.getDateFromString(null)); + assertEquals(badDate, DateUtilFunctions.getDateFromString("1975-13-56")); + assertEquals(badDate, DateUtilFunctions.getDateFromString("1975-1s")); Review Comment: @jnturton I'm a little stuck here. I did a bunch of experimentation, and right now, if the input is `null`, the function will return `null`. However, if the input is unparsable, then the output is Jan 1, 1970 because the value of the `TimestampHolder` is `0`. My goal is to make it so that if the input is not parsable, it will also return `null`, however I can't seem to get it to do that. I've tried using a `NullableTimestampHolder` as output and simply setting the value to `null` or not setting it at all. but When I do that, the function does not work at all. Meaning that in the unit tests, ALL results come back as `null`. @vvysotskyi Any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
