jnturton commented on code in PR #2714: URL: https://github.com/apache/drill/pull/2714#discussion_r1042270417
########## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/BoxFileSystem.java: ########## @@ -0,0 +1,459 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.store.dfs; + +import com.box.sdk.BoxAPIConnection; +import com.box.sdk.BoxFile; +import com.box.sdk.BoxFolder; +import com.box.sdk.BoxFolder.Info; +import com.box.sdk.BoxItem; +import com.box.sdk.BoxSearch; +import com.box.sdk.BoxSearchParameters; +import com.box.sdk.PartialCollection; +import org.apache.commons.io.FilenameUtils; +import org.apache.commons.lang3.StringUtils; +import org.apache.drill.common.exceptions.UserException; +import org.apache.drill.common.logical.security.CredentialsProvider; +import org.apache.drill.exec.oauth.PersistentTokenTable; +import org.apache.drill.exec.store.security.oauth.OAuthTokenCredentials; +import org.apache.drill.exec.store.security.oauth.OAuthTokenCredentials.Builder; +import org.apache.hadoop.fs.FSDataInputStream; +import org.apache.hadoop.fs.FSDataOutputStream; +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.fs.permission.FsPermission; +import org.apache.hadoop.util.Progressable; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.ByteArrayOutputStream; +import java.io.FileNotFoundException; +import java.io.IOException; +import java.net.URI; +import java.net.URISyntaxException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.Date; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + + +public class BoxFileSystem extends OAuthEnabledFileSystem { + + private static final Logger logger = LoggerFactory.getLogger(BoxFileSystem.class); + private static final String TIMEOUT_DEFAULT = "5000"; + private static final List<String> SEARCH_CONTENT_TYPES = new ArrayList<>(Collections.singletonList("name")); + private Path workingDirectory; + private BoxAPIConnection client; + private String workingDirectoryID; + private BoxFolder rootFolder; + private boolean usesDeveloperToken; + private final List<String> ancestorFolderIDs = new ArrayList<>(); + private final Map<Path, BoxItem> itemCache = new HashMap<>(); + + /** + * Returns a URI which identifies this FileSystem. + * + * @return the URI of this filesystem. + */ + @Override + public URI getUri() { + try { + return new URI("box:///"); + } catch (URISyntaxException e) { + throw new RuntimeException(e); + } + } + + /** + * Opens an FSDataInputStream at the indicated Path. + * + * @param inputPath the file name to open + * @param bufferSize the size of the buffer to be used. + * @throws IOException IO failure + */ + @Override + public FSDataInputStream open(Path inputPath, int bufferSize) throws IOException { + client = getClient(); + ByteArrayOutputStream out = new ByteArrayOutputStream(); + + BoxItem item = getItem(inputPath); + if (item instanceof BoxFile) { + BoxFile file = (BoxFile) getItem(inputPath); + updateTokens(); + + file.download(out); + updateTokens(); + + FSDataInputStream fsDataInputStream = new FSDataInputStream(new SeekableByteArrayInputStream(out.toByteArray())); Review Comment: We're buffering query data into heap memory here, something we don't want to do, but I've just created DRILL-8367 so that we work through all of the places where this is done in a separate exercise. ########## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/SeekableByteArrayInputStream.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.store.dfs; + +import org.apache.hadoop.fs.PositionedReadable; +import org.apache.hadoop.fs.Seekable; + +import java.io.ByteArrayInputStream; +import java.io.IOException; + +public class SeekableByteArrayInputStream extends ByteArrayInputStream implements Seekable, PositionedReadable { Review Comment: There's already a SeekableBAIS in the codebase which I think will do the same thing without adding a class. In Drill-8367 we can remove the use of that. ########## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/BoxFileSystem.java: ########## @@ -0,0 +1,459 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.store.dfs; + +import com.box.sdk.BoxAPIConnection; +import com.box.sdk.BoxFile; +import com.box.sdk.BoxFolder; +import com.box.sdk.BoxFolder.Info; +import com.box.sdk.BoxItem; +import com.box.sdk.BoxSearch; +import com.box.sdk.BoxSearchParameters; +import com.box.sdk.PartialCollection; +import org.apache.commons.io.FilenameUtils; +import org.apache.commons.lang3.StringUtils; +import org.apache.drill.common.exceptions.UserException; +import org.apache.drill.common.logical.security.CredentialsProvider; +import org.apache.drill.exec.oauth.PersistentTokenTable; +import org.apache.drill.exec.store.security.oauth.OAuthTokenCredentials; +import org.apache.drill.exec.store.security.oauth.OAuthTokenCredentials.Builder; +import org.apache.hadoop.fs.FSDataInputStream; +import org.apache.hadoop.fs.FSDataOutputStream; +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.fs.permission.FsPermission; +import org.apache.hadoop.util.Progressable; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.ByteArrayOutputStream; +import java.io.FileNotFoundException; +import java.io.IOException; +import java.net.URI; +import java.net.URISyntaxException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.Date; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + + +public class BoxFileSystem extends OAuthEnabledFileSystem { + + private static final Logger logger = LoggerFactory.getLogger(BoxFileSystem.class); + private static final String TIMEOUT_DEFAULT = "5000"; + private static final List<String> SEARCH_CONTENT_TYPES = new ArrayList<>(Collections.singletonList("name")); + private Path workingDirectory; + private BoxAPIConnection client; + private String workingDirectoryID; + private BoxFolder rootFolder; + private boolean usesDeveloperToken; + private final List<String> ancestorFolderIDs = new ArrayList<>(); + private final Map<Path, BoxItem> itemCache = new HashMap<>(); + + /** + * Returns a URI which identifies this FileSystem. + * + * @return the URI of this filesystem. + */ + @Override + public URI getUri() { + try { + return new URI("box:///"); + } catch (URISyntaxException e) { + throw new RuntimeException(e); + } + } + + /** + * Opens an FSDataInputStream at the indicated Path. + * + * @param inputPath the file name to open + * @param bufferSize the size of the buffer to be used. + * @throws IOException IO failure + */ + @Override + public FSDataInputStream open(Path inputPath, int bufferSize) throws IOException { + client = getClient(); + ByteArrayOutputStream out = new ByteArrayOutputStream(); + + BoxItem item = getItem(inputPath); + if (item instanceof BoxFile) { + BoxFile file = (BoxFile) getItem(inputPath); Review Comment: ```suggestion BoxFile file = (BoxFile) item; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
