vvysotskyi commented on code in PR #2718:
URL: https://github.com/apache/drill/pull/2718#discussion_r1046827000
##########
contrib/format-deltalake/src/main/java/org/apache/drill/exec/store/delta/format/DeltaFormatPluginConfig.java:
##########
@@ -18,15 +18,55 @@
package org.apache.drill.exec.store.delta.format;
import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonTypeName;
+import org.apache.drill.common.PlanStringBuilder;
import org.apache.drill.common.logical.FormatPluginConfig;
+import java.util.Objects;
+
@JsonTypeName(DeltaFormatPluginConfig.NAME)
public class DeltaFormatPluginConfig implements FormatPluginConfig {
public static final String NAME = "delta";
+ private final Long version;
+ private final Long timestamp;
+
@JsonCreator
- public DeltaFormatPluginConfig() {
+ public DeltaFormatPluginConfig(@JsonProperty("version") Long version,
Review Comment:
It will fail with the following error:
```
Invalid type definition for type
`org.apache.drill.exec.store.delta.format.DeltaFormatPluginConfig`: Argument #0
of constructor [constructor for
`org.apache.drill.exec.store.delta.format.DeltaFormatPluginConfig` (2 args),
annotations: {interface
com.fasterxml.jackson.annotation.JsonCreator=@com.fasterxml.jackson.annotation.JsonCreator(mode=DEFAULT)}
has no property name (and is not Injectable): can not use as property-based
Creator
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
