jnturton commented on code in PR #2713:
URL: https://github.com/apache/drill/pull/2713#discussion_r1049256392
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemConfig.java:
##########
@@ -53,18 +53,23 @@ public class FileSystemConfig extends StoragePluginConfig {
public static final String NAME = "file";
private final String connection;
+ private final String[] mountCommand, unmountCommand;
Review Comment:
@cgivre apologies, I missed this. The motivation was runtime efficiency
since I don't need the (admittedly very small) overhead of dynamic collections
here. The Runtime.exec method that I hand off to is also based on String[] so
by matching that I don't need to do a List to array conversion. Are Lists
preferable when working with arrays from Jackson though, because I can
certainly change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
