jnturton opened a new pull request, #2777:
URL: https://github.com/apache/drill/pull/2777

   # [DRILL-8409](https://issues.apache.org/jira/browse/DRILL-8409): Support 
the configuration of bind addresses for network services
   
   ## Description
   
   Drill provides the DRILL_HOST_NAME env var which determines what Drillbit 
host name will be exchanged over RPC for later look up by a remote client or 
Drillbit. This host name is used to check whether Drill is being asked to bind 
to the loopback address in distributed mode
   ```
       if (isDistributedMode && 
InetAddress.getByName(hostName).isLoopbackAddress()) {
         throw new DrillbitStartupException("Drillbit is disallowed to bind to 
loopback address in distributed mode.");
       }
   ```
   but is not ever used set the bind address used for the Drillbit's RPC and 
web ports! This PR adds new boot options
   ```
   drill.exec.rpc.bind_addr
   drill.exec.http.bind_addr
   ```
   and uses them to set the bind addresses used for RPC services and the HTTP 
service respectively.
   
   ## Documentation
   Document all three of DRILL_HOST_NAME and the two new bind address options.
   
   ## Testing
   Provide no bind addresses and confirm that the effective previous default 
(0.0.0.0) is applied.
   Manually set bind addresses and test that Drill is not accessible on other 
local addresses.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to