jnturton commented on code in PR #2794: URL: https://github.com/apache/drill/pull/2794#discussion_r1168863776
########## exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/conversion/DrillRexBuilder.java: ########## @@ -65,9 +65,9 @@ public RexNode ensureType( * @return Call to CAST operator */ @Override - public RexNode makeCast(RelDataType type, RexNode exp, boolean matchNullability) { + public RexNode makeCast(RelDataType type, RexNode exp, boolean matchNullability, boolean safe) { Review Comment: They did do this and only deprecated the original method so our build wasn't broken but our subclass DrillRexBuilder was broken in terms of runtime logic because our method override no longer took effect when it needed to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org