jnturton commented on code in PR #2805:
URL: https://github.com/apache/drill/pull/2805#discussion_r1199746266
##########
pom.xml:
##########
@@ -562,7 +562,6 @@
<includeOnlyProperty>^git\.commit\..*$</includeOnlyProperty>
<includeOnlyProperty>^git\.dirty$</includeOnlyProperty>
<includeOnlyProperty>^git\.tags$</includeOnlyProperty>
-
<includeOnlyProperty>^git\.total\.commit\.count$</includeOnlyProperty>
Review Comment:
Thank you for this. I'd have thought that the count of the commits leading
to up to some tagged commit _is_ reproducible? Or are we catering for the case
where a build system makes a shallow clone for efficiency and that truncates
the commit history?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
