cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1375364162
##########
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##########
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReaderConfig
readerConfig, EasySubScan scan,
this.validationMode = formatConfig.getValidationMode();
//
- // FIXME: Next, a MIRACLE occurs.
+ // FIXME: Where is this config file to be found? And, what is its syntax?
//
- // We get the dfdlSchemaURI filled in from the query, or a default config
location
- // We get the rootName (or null if not supplied) from the query, or a
default config location
- // We get the rootNamespace (or null if not supplied) from the query, or a
default config location
- // We get the validationMode (true/false) filled in from the query or a
default config location
- // We get the dataInputURI filled in from the query, or from a default
config location
- //
- // For a first cut, let's just fake it. :-)
+ // FIXME: How do I arrange for these same things to be overriddable in the
query
+ // or has that already happened before we get these things?
Review Comment:
This has already happened. If you need any variables to be configurable by
the user, just add them to `DaffodilFormatConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
