cgivre commented on PR #2853: URL: https://github.com/apache/drill/pull/2853#issuecomment-1849004555
> @cgivre I'm not that familiar with how Drill plugin configurations work. If I was to extend IcebergFormatPluginConfig to add a configurable allowPackageList (`String[]` or `List<String>` -- whichever works best) -- how would I go about accessing this from the IcebergWork class. It is IcebergWork where I need to apply the allow list? It think the thing to do would be to add an argument to the `IcebergWork` constructor. Then once that's done, it looks like the `IcebergWork` is instantiated in the `IcebergGroupScan`. https://github.com/apache/drill/blob/fe57fd11bf61a0835e4295f6822c4e1b0a045bfa/contrib/format-iceberg/src/main/java/org/apache/drill/exec/store/iceberg/IcebergGroupScan.java#L236-Ll44 The GroupScan has access to the `IcebergPlugin` and from there you can access the IcebergConfig. Does that make sense? > > @vvysotskyi you appear to have written most of the Iceberg code. Would you have any idea if this issue is one that we need to worry about? If it is, it looks like it will be hard to get the config values injected into IcebergWork because the class seems to only be instantiated by a custom Jackson Deserializer that itself only created only Java reflection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
