cgivre commented on code in PR #2909:
URL: https://github.com/apache/drill/pull/2909#discussion_r1582206247
##########
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/MapBuilder.java:
##########
@@ -185,6 +192,26 @@ public MapBuilder resumeMap() {
return (MapBuilder) parent;
}
+ /**
+ * Depending on whether the parent is a schema builder or map builder
+ * we resume appropriately.
+ */
+ @Override
+ public void resume() {
+ if (Objects.isNull(parent))
Review Comment:
@mbeckerle Confirmed. I successfully built your branch by adding the
aforementioned braces. I'll save you some additional trouble. There's another
check style violation in `DaffodilBatchReader`. Drill doesn't like star
imports for some reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
