rymarm opened a new pull request, #2923:
URL: https://github.com/apache/drill/pull/2923
This PR removes unused properties and 1 duplicate property.
During an investigation of the Drill configuration system, I noticed Drill
has several system options(`drill.exec.options.*` properties), which are absent
in `SystemOptionManager`, but present in `DrillConfig`:
```sql
apache drill> select name from sys.boot where name like
'drill.exec.options%' AND name not in (select concat('drill.exec.options.',
name) from sys.internal_options union all select concat('drill.exec.options.',
name) from sys.options);
+-------------------------------------------------------+
| name |
+-------------------------------------------------------+
| drill.exec.options.drill.exec.testing.controls |
| drill.exec.options.exec.hashagg.max_batches_in_memory |
| drill.exec.options.exec.hashagg.num_rows_in_batch |
| drill.exec.options.exec.hashjoin.mem_limit |
| drill.exec.options.exec.return_result_set_for_ddl |
+-------------------------------------------------------+
```
I've analyzed the Drill code and concluded:
1. `drill.exec.options.drill.exec.testing.controls` - is set to empty in
`drill-module.conf` in `java-exec` jar. This property becomes available only
when an assertions mode is enabled. All the other time this option is never
used and should not be initialized. Even with enabled assertions mode a `null`
value is acceptable.
2. `drill.exec.options.exec.hashagg.max_batches_in_memory` - is set to 65536
in `drill-module.conf` in `java-exec` jar. This property is never used.
3. ` drill.exec.options.exec.hashagg.num_rows_in_batch` - is set to 128 in
`drill-module.conf` in `java-exec` jar. This property is never used.
4. `drill.exec.options.exec.hashjoin.mem_limit` - is set to 0 in
`drill-module.conf` in `java-exec` jar. This property is never used.
5. `drill.exec.options.exec.return_result_set_for_ddl` - is set to `true`.
This property is probably a typo of
`drill.exec.options.exec.query.return_result_set_for_ddl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
