rymarm commented on PR #2937: URL: https://github.com/apache/drill/pull/2937#issuecomment-2317456893
@jnturton @paul-rogers could you please take a look? Drill has a hidden issue caused by the following change: https://github.com/apache/drill/pull/909/files#diff-437f42bceabae9bccd3ff19064898dc0d03df3dd40fcdbe5051c9fcced433c94R245-R247 This change caused a little-noticeable problem, that makes `ParquetSchema#createMissingColumn` to create a "dummy" column but with backticks in the name of the column: ``` Error: UNSUPPORTED_OPERATION ERROR: Schema changes not supported in External Sort. Please enable Union type. Previous schema: BatchSchema [fields=[[`age` (INT:OPTIONAL)]], selectionVector=NONE] Incoming schema: BatchSchema [fields=[[`age` (INT:OPTIONAL)], [``age`` (INT:OPTIONAL)]], selectionVector=NONE] ``` This change was definitely made intentionally, but the purpose of the change is not clear to me. @ychernysh and I think this change needs to be reverted, but maybe we missed something. At this moment some of deltalake test fails due to this change, but before we move on, we would like to know, whether it's a good idea to keep using `col.getAsUnescapedPath()` instead of `col.toExpr()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
